libgui/src/resource-manager.cc contains removed function names. Should we remove them?

[Andreas Weber]

Dear octave maintainers,
I'm currently searching and removing references to already removed
functions and stumbled over resource-manager.cc.

>From NEWS:
"   The following functions were deprecated in Octave 3.2 and have been
    removed from Octave 3.6.

      create_set          spcholinv    splu
      dmult               spcumprod    spmax
      iscommand           spcumsum     spmin
      israwcommand        spdet        spprod
      lchol               spdiag       spqr
      loadimage           spfind       spsum
      mark_as_command     sphcat       spsumsq
      mark_as_rawcommand  spinv        spvcat
      spatan2             spkron       str2mat
      spchol              splchol      unmark_command
      spchol2inv          split        unmark_rawcommand"


but these functions are still in resource-manager.cc. I'm not familiar
with this but I guess the resource_manager::octave_keywords are, for
example, used for syntax highlighting?

Can I remove the "removed functions" from resource-manager.cc or is
there a reason to keep them there?

libgui/src/resource-manager.cc:611:      "create_set "
libgui/src/resource-manager.cc:691:      "dmult "
libgui/src/resource-manager.cc:1020:      "iscommand "
libgui/src/resource-manager.cc:1065:      "israwcommand "
libgui/src/resource-manager.cc:1103:      "lchol "
libgui/src/resource-manager.cc:1122:      "loadimage "
libgui/src/resource-manager.cc:1162:      "mark_as_command "
libgui/src/resource-manager.cc:1163:      "mark_as_rawcommand "
libgui/src/resource-manager.cc:1512:      "spatan2 "
libgui/src/resource-manager.cc:1514:      "spchol "
libgui/src/resource-manager.cc:1515:      "spchol2inv "
libgui/src/resource-manager.cc:1516:      "spcholinv "
libgui/src/resource-manager.cc:1518:      "spcumprod "
libgui/src/resource-manager.cc:1519:      "spcumsum "
libgui/src/resource-manager.cc:1520:      "spdet "
libgui/src/resource-manager.cc:1521:      "spdiag "
libgui/src/resource-manager.cc:1522:      "spdiags "
libgui/src/resource-manager.cc:1530:      "spfind "
libgui/src/resource-manager.cc:1533:      "sphcat "
libgui/src/resource-manager.cc:1536:      "spinv "
libgui/src/resource-manager.cc:1537:      "spkron "
libgui/src/resource-manager.cc:1538:      "splchol "
libgui/src/resource-manager.cc:1540:      "split "
libgui/src/resource-manager.cc:1541:      "split_long_rows "
libgui/src/resource-manager.cc:1542:      "splu "
libgui/src/resource-manager.cc:1543:      "spmax "
libgui/src/resource-manager.cc:1544:      "spmin "
libgui/src/resource-manager.cc:1547:      "spprod "
libgui/src/resource-manager.cc:1548:      "spqr "
libgui/src/resource-manager.cc:1556:      "spsum "
libgui/src/resource-manager.cc:1557:      "spsumsq "
libgui/src/resource-manager.cc:1558:      "spvcat "
libgui/src/resource-manager.cc:1582:      "str2mat "
libgui/src/resource-manager.cc:1599:      "strsplit "
libgui/src/resource-manager.cc:1717:      "unmark_command "
libgui/src/resource-manager.cc:1718:      "unmark_rawcommand "

Regards, Andy