[Octave-patch-tracker] [patch #8960] Preliminary balancing and balance option for eig

[Nir Krakauer]

Follow-up Comment #1, patch #8960 (project octave):

You should have a series of test cases to make sure that the balance option
(and eventually the other options you'll be adding) work as planned. Since
putting tests in the source files of built-in functions is still under
discussion [1], I suggest for now just writing an m-file script that runs
tests for eig.

> I already know that in Matlab there is no option to change balance option in
the general case, but the documentation does not mention if the balancing is
default or not in the generalised case. How should I handle this?

I think balancing should be an option, but not the default, for the
generalized case.

> I think that balancing a Symmetric or a Hermitian matrix does nothing, so I
didn't touched those functions (so there is no balancing at all). Please
correct me if I am wrong. 

I believe you're right.

> I am also not sure what to do in case of an invalid string input.

Try checking what Matlab does in this case and doing likewise.

[1] http://savannah.gnu.org/bugs/?47424

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8960>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/