|
From: | anonymous |
Subject: | [Octave-patch-tracker] [patch #9084] uitable implementation |
Date: | Fri, 12 Aug 2016 16:58:48 +0000 (UTC) |
User-agent: | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 |
Follow-up Comment #2, patch #9084 (project octave): Hi Matt, Thanks for looking at this. I'm not sure I understand how you want the separate changeset to be generated. Do you just want a diff just containing the changes: * libinterp/corefcn/pr-output.cc: Make rational_approx non-static - needed for columnformat in uitable * libinterp/corefcn/pr-output.h: Expose rational_approx in pr-output.h * libinterp/corefcn/str2double.cc: Expose str2double1 as str2double_internal - needed to interpret data edits * libinterp/corefcn/str2double.h: Expose str2double_internal They're really very small changes - moving a static function into the non-static space and sticking a stub in to the header file. Both functions are completely stateless and would therefore be safe - I would have reimplemented them otherwise. I'll add a demo to my next patch set and prod the NEWS file - I knew I'd forgotten something. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/patch/?9084> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |