octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9077] image package: new function imfill.


From: Carnë Draug
Subject: [Octave-patch-tracker] [patch #9077] image package: new function imfill.m
Date: Mon, 15 Aug 2016 01:18:45 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Follow-up Comment #11, patch #9077 (project octave):

The only real issue now is about connectivities other than 4 and 8.  Your
check is too rigorous.  It should allow connectivity of class double and also
things such as "eye (3)". And disabling the checks, it shows a bug on the
approach.

I have made more detailed comments online, including a code example showing
the bug.

I pushed your changes to my draft clone of the Octave image repository.  I
think this will make it simple for me to review changes and if you also have a
clone there, for you to ask for review. Instead of preparing a whole new cset,
I can see only what changed and you don't have to export and upload a new file
each time.  Don't worry about having multiple commits and commit message now.
In the end, I'll fold all into one with your name (the trick is on setting the
repository in bitbucket as non-publishing on the settings).

See
https://bitbucket.org/carandraug/octave-image/commits/400498c55fb6622a7664e37ab8f6eb07f3c3f3ec
or checkout bookmark "new-function-imfill-patch-9077"

https://bitbucket.org/carandraug/octave-image/commits/branch/new-function-imfill-patch-9077

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9077>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]