Re: [Openexr-devel] iif-optimisations branch tests

[Al Crate]

Ah that might be it . The Hero thing..

exrheader sxr/o_ldev_pipe_sxr_flip_test_v001.0000.sxr

sxr/o_ldev_pipe_sxr_flip_test_v001.0000.sxr:

file format version: 2, flags 0x0
capDate (type string): "2012:03:01 14:00:09"
channels (type chlist):
    A, 16-bit floating-point, sampling 1 1
    B, 16-bit floating-point, sampling 1 1
    G, 16-bit floating-point, sampling 1 1
    R, 16-bit floating-point, sampling 1 1
    right.A, 16-bit floating-point, sampling 1 1
    right.B, 16-bit floating-point, sampling 1 1
    right.G, 16-bit floating-point, sampling 1 1
    right.R, 16-bit floating-point, sampling 1 1
comments (type string): "Created by exr2sxr"
compression (type compression): piz
dataWindow (type box2i): (0 0) - (1023 777)
displayWindow (type box2i): (0 0) - (1023 777)
left.dataWindow (type box2i): (0 0) - (1023 777)
lineOrder (type lineOrder): decreasing y
multiView (type stringvector):
    "left"
    "right"
owner (type string): "mungo"
pixelAspectRatio (type float): 1
preview (type preview): 100 by 76 pixels
right.dataWindow (type box2i): (0 0) - (1023 777)
screenWindowCenter (type v2f): (0 0)
screenWindowWidth (type float): 1


On 03/04/13 03:46, Peter Hillman wrote:
> Hi Al,
>
> Which view is hero in your input, and which branch did you build from?
> The iif-optimisations branch doesn't fully support right-view-is-hero
> multiview EXRs. I think it would push black into the left view. The
> iif-weta branch supports both left and right view as hero. It is a
> redesign of iif-optimisations which keeps the ABI closer to 1.7.1
>
> The develop branch also has optimisation as part of the EXR-2.0
> codebase, which should work for both left and right hero multiview files.
>
> If symptoms persist there is a commented out line in
> ImfScanLineInputFile.cpp which disables the optimised path. That might
> help debug the problem:
>
> // TODO-pk this disables optimization
> // _data->optimizationMode._destination._format =
> Imf::OptimizationMode::PIXELFORMAT_OTHER;
>
> Peter
>
>
> On 04/03/2013 03:12 PM, Piotr Stanczyk wrote:
> > Hi Al,
> >
> > I had a look and I can't seem to find any issues, which worries me as
> > you may be bumping into something not quite seen yet.
> >
> > Could you give me an idea as to what you were doing to prompt the
> > failure? Are you reading existing imagery with a tool linked against
> > v2.0?
> > Or are you writing out stereo images with v2 code base?
> >
> > Either way, what is exrheader giving you?
> >
> > Piotr
> >
> >
> > ________________________________________
> > From: address@hidden
> > address@hidden on behalf of Al
> > Crate address@hidden
> > Sent: 02 April 2013 04:57
> > To: address@hidden
> > Subject: Re: [Openexr-devel] iif-optimisations branch tests
> >
> > On 20/03/13 10:32, Al Crate wrote:
> > > Hi all,
> > >
> > > Just built the iff-optimised version, I tweaked the code in IlmImfTest
> > > to spit out some timings between the aligned and unaligned tests.
> > >
> > > The timings are almost identical, which isn't what I'd expect, is there
> > > anything I should be doing here to make this work, I also tried using
> > > the optimised libraries in our playback tool and that showed little to
> > > no speed improvements.
> > >
> > > I'm guessing I'm not using these correctly, is there some compiler
> > > option I require or memory alignment needed?
> > >
> > > cheers
> > >
> > > al
> > >
> > >
> > > _______________________________________________
> > > Openexr-devel mailing list
> > > address@hidden
> > > https://lists.nongnu.org/mailman/listinfo/openexr-devel
> >
> > I've noticed than stereo images don't seem to be working, it's missing
> > the left channel (it's black).
> >
> > OpenExr 1.7.1 works as expected though, has something changed with this?
> >
> > Anyone else noticed this issue ?
> >
> > _______________________________________________
> > Openexr-devel mailing list
> > address@hidden
> > https://lists.nongnu.org/mailman/listinfo/openexr-devel
> >
> > _______________________________________________
> > Openexr-devel mailing list
> > address@hidden
> > https://lists.nongnu.org/mailman/listinfo/openexr-devel
>
>
> _______________________________________________
> Openexr-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/openexr-devel