[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Openexr-devel] IlmImf/ImfSystemSpecific.cpp and cpuid
From: |
Richard PALO |
Subject: |
[Openexr-devel] IlmImf/ImfSystemSpecific.cpp and cpuid |
Date: |
Wed, 13 Aug 2014 19:05:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; SunOS i86pc; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
Hi, came across build issues and the above file..
In particular, it fails when building PIC as the asm code doesn't deal
with all the possible cases...
Fortunately the code was already strobed with __GNUC__, so I updated to
use the gcc builtin __get_cpuid which does all the work.
I took advantage of the occasion to rectify the ints to be unsigned as
we're dealing with registers here.
Patch proposal is attached.
Wanting to test this, I came across an issue here as well for SunOS, so
I add as well a second patch to correctly include unistd.h for this
platform in IlmImfTest/main.cpp.
Unfortunately the test fails anyway as there is a file not found named
'comp_dwaa_v1.exr'. Can't seem to find it anywhere. Any hints?
cheers
patch-IlmImf_ImfSystemSpecific.cpp
Description: Text document
patch-IlmImfTest_main.cpp
Description: Text document