Re: [Openexr-devel] IlmImf/ImfSystemSpecific.cpp and cpuid

[Karl Rasche]

Thanks for the patch;  my asm-fu is weak.

That exr file is at least in github, under OpenEXR/IlmImfTest. Any chance you're hitting a path issue, or is the file actually missing from your download?

karl

On Wednesday, August 13, 2014, Richard PALO <address@hidden> wrote:

Hi, came across build issues and the above file..
In particular, it fails when building PIC as the asm code doesn't deal with all the possible cases...

Fortunately the code was already strobed with __GNUC__, so I updated to use the gcc builtin __get_cpuid which does all the work.

I took advantage of the occasion to rectify the ints to be unsigned as we're dealing with registers here.

Patch proposal is attached.

Wanting to test this, I came across an issue here as well for SunOS, so I add as well a second patch to correctly include unistd.h for this platform in IlmImfTest/main.cpp.

Unfortunately the test fails anyway as there is a file not found named 'comp_dwaa_v1.exr'.  Can't seem to find it anywhere.  Any hints?

cheers