Re: [Pan-users] check for new headers not working...

[Charles Kerr]

On Wed, Mar 26, 2003 at 03:28:48PM +0000, Brian Morrison wrote:
> >On Mon, Mar 24, 2003 at 11:56:07PM -0800, Chris Petersen wrote:
> >> > After deleting my config.xml and trying prefs-change-apply-ok-prefs
> >> > as you suggest, I'm not able to duplicate the problem.  Could you give
> >> > a more step-by-step recipe?
> >> 
> >> Not really sure.  I change one or several of those three "load headers"
> >> selections, ok (apply is obviously redundant), and then go back to
> >> prefs.  sometimes they change, sometimes they don't. As best as I can
> >> tell, the first two don't stick - sometimes selecting the first two
> >> leaves the third checked, sometimes they all get disabled.  thus, as far
> >> as I can tell, either I get all three enabled, or only get the first one
> >> enabled (or possibly all disabled - haven't tried that one yet).
> >
> >Ah, I see.  Fixed in CVS:
> >
> >Index: prefs.c
> >===================================================================
> >RCS file: /cvs/gnome/pan/pan/prefs.c,v
> >retrieving revision 1.340
> >diff -u -r1.340 prefs.c
> >--- prefs.c     24 Mar 2003 00:09:14 -0000      1.340
> >+++ prefs.c     25 Mar 2003 08:29:10 -0000
> >@@ -642,7 +642,7 @@
> >  
> >        update_entry_and_bool_from_toggle_button (
> >                &fetch_new_and_bodies_on_startup,
> >-               KEY_FETCH_NEW_FROM_SUBSCRIBED_ON_STARTUP,
> >+               KEY_FETCH_NEW_AND_BODIES_ON_STARTUP,
> >                win->fetch_new_and_bodies_on_startup_cbutton);
> >  
> >        if (update_entry_and_bool_from_toggle_button (
> >
> >Time for bed.
> 
> OK, before applying this patch I could not get either fetch new headers
> on startup or fetch new headers and bodies on startup to stay selected
> after closing prefs or exiting Pan and restarting it.
> 
> After applying the patch fetch new headers on startup stays selected OK
> but now I can't get the fetch new headers and bodies on startup to stay
> deselected when closing prefs or exiting Pan. I haven't tried turning
> off both and closing and reopening prefs yet.
> 
> I take it this was not intended behaviour Charles....
> 
> ;-)

Yes, it was three in the morning when I sent that out.
Here's part two of the fix, now quit yer whining. ;)

http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=prefs.c&rev1=1.341&rev2=1.342&root=/cvs/gnome