Re: [pdf-devel] pdf_functions, patch

[jemarch]

   I'm ready to prepare a patch to libgnupdf with cvs diff -up. 

Nice, thanks.

   The patchfile showed some of my modifications to pdf_obj.c:

   pdf_dealloc_obj() does not handle stream objects.
   pdf_stream_dup() and pdf_create_stream duplicate the dictionary  
   but it is never freed.

   Proposed modification:
   do not pdf_obj_dup() the dictionary,
   but destroy it in pdf_destroy_obj.
   Please check or tell me where I misread the code.

I am going to install a patch for pdf_obj.[ch] that changes the way
memory is managed. Dont worry about that: I will adapt your patch
before to commit it.

   One additional question:
   How can I add files in my patch?

Just concat a diff against an empty file to the patch generated by cvs
diff:

  $ cvs diff -up > mypatch
  $ diff -u empty-file new/file.c >> mypatch
  ...

-- 
Jose E. Marchesi  <address@hidden>
                  <address@hidden>

GNU Spain         http://es.gnu.org
GNU Project       http://www.gnu.org