[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] testsuite
|
From: |
jemarch |
|
Subject: |
Re: [pdf-devel] testsuite |
|
Date: |
Thu, 08 Nov 2007 12:18:34 +0100 |
|
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/22.0.93 (x86_64-unknown-linux-gnu) MULE/5.0 (SAKAKI) |
Valgrind -- I like it! -- complains heavily on
pdf_create_date(), both with
invalid read and invalid write.
The parser is far too complicated, imho :-(
Yes.
address@hidden:~/gnu/src/libgnupdf/src$ pmccabe pdf_date.c
40 42 91 286 177 pdf_date.c(287): pdf_date_parse
Its corrected cyclomatic complexity is 40. Far too high. It should be
simplified.
--
Jose E. Marchesi <address@hidden>
Project Engineer
Real Time System Division
Deimos Space, SL (http://www.deimos-space.com)