[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Error module implementation
From: |
gerel |
Subject: |
Re: [pdf-devel] Error module implementation |
Date: |
Sun, 24 Feb 2008 17:53:57 -0300 |
> Date: Sun, 24 Feb 2008 21:38:39 +0100
> From: Aleksander Morgado <address@hidden>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
> Content-Transfer-Encoding: 7bit
>
> Hi gerel,
>
> Just a couple of comments,
>
>
> > int pdf_error_one_per_line = 1;
>
> Is this variable going to be modified at runtime?
As you said I'm not sure of that variable, let's remove it for now.
>
> > fprintf (fd, "GNU PDF");
>
> You can use the `program_name' variable from pdf-global.c:
> ./src/pdf-global.c:char *program_name = "libgnupdf";
>
Sure.
>
> > if (format != NULL)
> > {
> > fprintf (fd, ": ");
> > va_start (args, format);
> > vfprintf (fd, format, args);
> > }
>
> The macro `va_end' should be called after having called `va_start', even
> if GCC does nothing with it (portability issues).
>
Sorry, I forgot.
Thank for your comments Aleksander :-)
cheers
-gerel