[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Error module patches
From: |
Aleksander Morgado |
Subject: |
Re: [pdf-devel] Error module patches |
Date: |
Wed, 27 Feb 2008 17:05:10 +0100 |
User-agent: |
Thunderbird 2.0.0.9 (Macintosh/20071031) |
Hi Gerel,
I found a problem in the PDF_DEBUG_* macros in pdf-error.h. If the
debugging is not enabled, these macros shouldn't be expanded to "". In
addition to this, they should always be defined as variadic macros, to
avoid compiler warnings.
So, the following line:
#define PDF_DEBUG_BASE ""
Should be written as:
#define PDF_DEBUG_BASE(...)
And so on for the other PDF_DEBUG_* macros.
I attach the simple patch.
BTW, the `--enable-debug-[base|object|document|page]' configure options
are still not available in configure.ac
Best regards!
-Aleksander
Index: pdf-error.h
===================================================================
RCS file: /cvsroot/pdf/libgnupdf/src/base/pdf-error.h,v
retrieving revision 1.2
diff -r1.2 pdf-error.h
36c36
< #define PDF_DEBUG_BASE ""
---
> #define PDF_DEBUG_BASE(...)
44c44
< #define PDF_DEBUG_OBJECT ""
---
> #define PDF_DEBUG_OBJECT(...)
52c52
< #define PDF_DEBUG_DOCUMENT ""
---
> #define PDF_DEBUG_DOCUMENT(...)
60c60
< #define PDF_DEBUG_PAGE ""
---
> #define PDF_DEBUG_PAGE(...)