[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Error module patches
From: |
gerel |
Subject: |
Re: [pdf-devel] Error module patches |
Date: |
Thu, 28 Feb 2008 11:39:05 -0300 |
> Date: Thu, 28 Feb 2008 11:16:45 +0100
> From: Aleksander Morgado <address@hidden>
>
>
> Hi Gerel,
>
> There is still a minor issue in the PDF_DEBUG_* macros, when the
> corresponding configure option is enabled and no extra argument is given
> in addition to the formatting string, for example:
> PDF_DEBUG_BASE("Whatever");
>
> We get a compiler error, because __VA_ARGS__ is expanded to nothing, and
> we get the following expression:
> pdf_error (0, stderr, "***DEBUG BASE***:%s:%d: " "Whatever", __FILE__,
> __LINE__,);
>
> This statement is wrong due to the last comma before the parenthesis,
> which shouldn't appear.
>
> The fix is simple: instead of `__VA_ARGS__' we must use `##__VA_ARGS__',
> as the `##' will remove the previous comma if there is no extra argument.
I see, thanks for your help :-)
-gerel