[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Debug options: autotools errors
From: |
gerel |
Subject: |
Re: [pdf-devel] Debug options: autotools errors |
Date: |
Thu, 28 Feb 2008 11:18:17 -0300 |
> Date: Thu, 28 Feb 2008 10:38:00 +0100
> From: Aleksander Morgado <address@hidden>
>
> Hi Gerel,
>
> > ##
> > Error message:
> >
> > autoheader: warning: missing template:
> > autoheader: Use AC_DEFINE([], [], [Description])
> > autoreconf: /usr/bin/autoheader failed with exit status: 1
> > ###
> >
>
> You should use AC_DEFINE_UNQUOTED for shell variables only. But the real
> error is that the third parameter is not given (the description). The
> description is mandatory when you want to use autoheader (by calling
> AM_CONFIG_HEADER or AC_CONFIG_HEADERS) to create a config.h.in file with
> all the defines, as we do.
>
> In addition to this, the defines should only appear if the specific
> option was selected in the configure, and not always, even if the value
> defined is different (we use `ifdef' within the code, not `if').
>
> I send you my changes to your proposal.
Hey, many thanks!
I'd prefer to set each symbol to '1' though:
AC_DEFINE([HAVE_DEBUG_PAGE], [1], [Debugging Page Layer])
just to follow the standard in config.h symbols.
cheers
-gerel