pdf-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pdf-devel] Patch for FS#56 (second try)


From: jemarch
Subject: Re: [pdf-devel] Patch for FS#56 (second try)
Date: Mon, 21 Jul 2008 23:27:40 +0200
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Hi Gerel.

   address@hidden disp_fn
   +The function called when @var{element} is removed, can be NULL.

Would be good to explain there what the function does if the parameter
is NULL.

   +  if (pdf_hash_add (props_hash, "isHidden", (void *) is_hidden,NULL) !=
   +      PDF_OK)
   +    {
   +      return PDF_ERROR;
   +    }

Will the memory used by 'is_hidden' be released when the hash is
destroyed being the last parameter NULL? As far as I understand in
this case the dispose function defined for the hash will be applied.

Also, in the same function:

 newelt->key = key;
 ...
 gl_sortedlist_add ((gl_list_t)table.keys, key_compare, key);

Is 'gl_sortedlist_add' making a copy of 'key'?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]