[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Patch for FS#56 (second try)
|
From: |
jemarch |
|
Subject: |
Re: [pdf-devel] Patch for FS#56 (second try) |
|
Date: |
Wed, 23 Jul 2008 22:55:47 +0200 |
|
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
> The keys are always raw strings, isnt it? If it is the case I would
> say to let the hash implementation to make a copy of it and manage its
> memory.
Yes they're raw strings, but I chose to let the caller decide this since when
using statically allocated strings (as in many cases) we would be duplicating
strings for nothing. I'm not a PDF guru but I guess _many_ of the string keys
we're going to use are predefined in the standard. So, I don't agree on this
modification.
I agree.