Re: [pdf-devel] test suite broken (and infinite loop in stm module unit tests)

[Zac Brown]

address@hidden wrote:
> Hi Zac.
>
>    Apparently revision 515 (Jose?) broke our test suite.  Line 41:
>    "srunner_set_fork_status (sr, CK_FORK);" is to blame. Neither
>    CK_FORK nor srunner_set_fork_status are defined in
>    torture/unit/nocheck/check.[ch].
>
> Hum! I introduced the call to 'srunner_set_fork_status' to ease the
> transition to CF_NOFORK when debugging, but I forgot about our friend
> nocheck :)
>
> I think that a proper solution would be to add the
> srunner_set_fork_status in nocheck as a NO-OP and also the symbols
> CK_FORK and CK_NOFORK. nocheck doesnt support the fork mode, anyway.
>
>    Also, after fixing that, it appears the stream module test number 5
>    for pdf_stm_read is hanging in an infinite loop.
>
> It is because the runlength filter still has to be adapted to the
> latest modifications to the stream code.
>
> Thanks.

The patch to fix the above errors as well as remove extraneous deps in 
doc/Makefile.am is attached.

-Zac

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: address@hidden
# target_branch: http://bzr.savannah.gnu.org/r/pdf/libgnupdf/branches\
#   /trunk/
# testament_sha1: 44e121267bdc9fa67483b3b7a0a2ab72d05a66df
# timestamp: 2008-10-04 14:41:41 -0400
# base_revision_id: address@hidden
# 
# Begin patch
=== modified file 'doc/Makefile.am'
--- doc/Makefile.am     2008-07-27 12:54:24 +0000
+++ doc/Makefile.am     2008-10-04 18:40:05 +0000
@@ -16,14 +16,10 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-EXTRA_DIST = pdf_filter.1
-
 noinst_TEXINFOS = gnupdf-tsd.texi gnupdf-hg.texi
 info_TEXINFOS = gnupdf.texi gnupdf-utils.texi
 gnupdf_TEXINFOS = fdl.texi
 
-man_MANS = pdf_filter.1
-
 AM_MAKEINFOHTMLFLAGS = --no-headers --no-split
 
 if TEXI2HTML

=== modified file 'torture/unit/nocheck/check.c'
--- torture/unit/nocheck/check.c        2008-04-22 21:55:50 +0000
+++ torture/unit/nocheck/check.c        2008-10-04 18:40:05 +0000
@@ -227,5 +227,10 @@
   return 0;
 }
 
+void srunner_set_fork_status (SRunner *sr, enum print_output print_mode)
+{
+  /* Do nothing */
+}
+
 /* End of check.c */
 

=== modified file 'torture/unit/nocheck/check.h'
--- torture/unit/nocheck/check.h        2008-04-22 22:04:11 +0000
+++ torture/unit/nocheck/check.h        2008-10-04 18:40:05 +0000
@@ -86,7 +86,9 @@
   CK_NORMAL,
   CK_VERBOSE,
   CK_ENV,
-  CK_LAST
+  CK_LAST,
+  CK_FORK,
+  CK_NOFORK
 };
 
 /* Run all tests */
@@ -97,7 +99,7 @@
 int srunner_ntests_failed (SRunner *sr);
 void tcase_fn_start (const char *fname, const char *file, int line);
 void srunner_set_log (SRunner *sr, const char *fname);
-
+void srunner_set_fork_status (SRunner *sr, enum print_output print_mode);
 
 
 

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWf628OMAAqVfgEAQUXf//38P
nBC////6UAVMXgAGmAqSCCSSCMU8mmGphBPSTaT0mjJp6gYgBkOaYmTJowmCYmmATAIYIwIwCUTR
Sfop+qPUeUaabUAAAANGnqeFADmmJkyaMJgmJpgEwCGCMCMAkiBNACEyp4DQ1T0T1NPJMgDQaeo0
o9Ka7bcb5HHR4yqS7V6WwtnUbXjKVoFbPBCihpmQOMGaUYV4hyzz1xCy8hmvNnKHmlCKKqqCrHOm
D5hQal1alMHDQqdU8Z7kxTyTe1NL8k7IZwtp/bJmGU3Y42SGMwIvS1Rw9wDU1FHDubG/XLJdFJ4x
S4mcdggsnwCDdrDbgZQLy6sCI13Yji16oHDyCgSqUgMtO++kBbhG+LwoFwun1BhHHajLgvREu2qt
wsAdqMKAw7wvSj0xzYQMImgTk0eTIXQAwjl1naQXtFJxIgUKq8Z950+lTEk43ix16Ik3pH0TQuMH
wMgB6QPGRQoXmLfCmepjzf0TBguM6VW9KeZnihdjGT1Lg0NTE29mwsFjXMxwZ7Zb5xB2CVkUCkBB
gKAboE1FyOW+0pJbTgbsCUS0rWIrSQxS9O1rPYqrQhDUmwGKyVxK4cw3OWZlxzFpvMp3Rg+NgioT
MMhKBBwIXEx6k3G6ipM+a0IEAwJETdXc2GpikYJXjhutKYqmOyRVKSWbZDkVZRTYpobiZojgRIlT
cfNQE1uugpF5QaAb1eeQpLBKZnwT66mY5cgZMhOQsLSQiw5jHZeUIZkKVKlxyEbTAxLCQzkNaYUL
4XF5iUhkWlxIuL1NMnhtTAyIZhQUvPYaeZuYD0Y6cP8dxqDHUxmzEWDwTHT7ly8HhSBNnbnDKiFj
9NFBRffbQa76qwPhGlQ7C8ifJaXujmTarNRt7uOOLoIBDhwiRX1MvM8SQHgVIH09WEjj7SV6Lxev
gN7z4fENQ0p3VH87QwEbXoJhhfFj2L33d+oZzjrO4l7DuMxAu0O4eZSJDmXZ7Uiy/wYac2E5SbVY
TBWRkqRUMkfhbys8ORz7QtqH9rDNFNFOBkbzJQRxF+JoBVkSIUaCsgeVUEqCZSmkzaI3FAvitMUf
nvV5vE5LHmGLx5sG1YxU8F6g8iO1idp1CLA49JSOAyvVGXWEp9QshfrcrkyWA+Jitz3OIDjnDarl
HCSCHJSQ3a9RrPWrjgbum4zFvQWGI4gKNwWBaI8VUHBWLlmEXuIFT4ZRYJLID1DT17ftW4XaBe4D
9ugm57+/wvhl3G1BdU6Q5c/AShLjmFo1ThyxhjrzsgeI07Pl6CIk+pbr97Egh4jw1OwO3nFxPHFF
4lMm3u7o5+USStHEP56XhgohHntJc3G0hTaEewRvsgzOkMg6AnRpCdyLbwhK6c4hgpJJFGDJmS7A
YZym8+KxOY0lkuw1kqRjEjaLqSU6PVApn41XmiUE2gMccUbVfFGEkweQiGU5hbaNkYq06rzZBcBY
OjEXjWwNcHEYd8FiyhYkq0zCCKwgH33JEybGQ60LIvzmUIjN7FQ9hzYDAwa9Ah1RH0X9mwuUiwTt
ZiVcXHk5M6kugWURchOZCjR8En2nWQLKCqsCrwYmyPcLGhEiHfbxgcRF/yKEbsizqGUV47BHE5Hv
ERgniLKa+9ct+GSnAorqZmxnzqlcwifnwD+8D2IZd6RmDjTNcf8XckU4UJD+tvDj