Re: [pdf-devel] FS module unit test design

[jemarch]

Hello.

   after a few busy month I know finished university, found a new job
   and put everything else in order, so finally I have some more free
   time :)

Superb. Congratulations for finishing the univ and your new job :)

   Attached is what I have so far regarding the unit test design for the
   filesystem module.

Many thanks. There are some problems with the Texinfo sectioning. A
report with the compilation errors is appended to this email. The unit
tests seems to be quite good.

   What is missing are:

   pdf_fsys_file_flush

   I was not entirely sure, what this function is supposed to do. Does it
   flush all the data from an open file or just the data that was
   added?

The function should flush the output "buffer" of the open file, if
there is any in the underlying filesystem implementation. It is not
easy to test because the specific caching mechanism used by the
filesystem implementation is now known.

At least we should provide a simple positive test writing some data
into the file, calling flush and testing if the data has been written
into the file.

   pdf_fsys_create/pdf_fsys_destroy

For this function a simple positive test would be enough, I think.

Compilation errors:

address@hidden:~/gnu/src/libgnupdf/trunk/doc$ make gnupdf-tsd.info
restore=: && backupdir=".am$$" && \
        am__cwd=`pwd` && cd . && \
        rm -rf $backupdir && mkdir $backupdir && \
        if (/bin/sh /home/jemarch/gnu/src/libgnupdf/trunk/missing --run 
makeinfo --version) >/dev/null 2>&1; then \
          for f in gnupdf-tsd.info gnupdf-tsd.info-[0-9] 
gnupdf-tsd.info-[0-9][0-9] gnupdf-tsd.i[0-9] gnupdf-tsd.i[0-9][0-9]; do \
            if test -f $f; then mv $f $backupdir; restore=mv; else :; fi; \
          done; \
        else :; fi && \
        cd "$am__cwd"; \
        if /bin/sh /home/jemarch/gnu/src/libgnupdf/trunk/missing --run makeinfo 
  -I . \
         -o gnupdf-tsd.info gnupdf-tsd.texi; \
        then \
          rc=0; \
          cd .; \
        else \
          rc=$?; \
          cd . && \
          $restore $backupdir/* `echo "./gnupdf-tsd.info" | sed 's|[^/]*$||'`; \
        fi; \
        rm -rf $backupdir; exit $rc
gnupdf-tsd.texi:604: Node `pdf_fsys_file_get_size' previously defined at line 
566.
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:755: 
`pdf_fsys_file_reopen' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:744: 
`pdf_fsys_file_close' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:731: 
`pdf_fsys_file_cancle_ria' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:701: 
`pdf_fsys_file_has_ria' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:681: 
`pdf_fsys_file_request_ria' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:654: 
`pdf_fsys_file_write' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:626: 
`pdf_fsys_file_read' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:615: 
`pdf_fsys_file_set_size' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:577: 
`pdf_fsys_same_p' has no Up field (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:566: Next field of 
node `pdf_fsys_file_get_size' not pointed to (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:615: This node 
(pdf_fsys_file_set_size) has the bad Prev.
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:566: Prev reference 
to nonexistent node `pdf_fsys_file_same_p' (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:554: Next field of 
node `pdf_fsys_file_set_mode' not pointed to (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:566: This node 
(pdf_fsys_file_get_size) has the bad Prev.
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:159: Menu reference 
to nonexistent node `pdf_fsys_file_same_p' (perhaps incorrect sectioning?).
/home/jemarch/gnu/src/libgnupdf/trunk/doc//gnupdf-tsd.texi:577: warning: 
unreferenced node `pdf_fsys_same_p'.
makeinfo: Removing output file `gnupdf-tsd.info' due to errors; use --force to 
preserve.
make: *** [gnupdf-tsd.info] Error 1
address@hidden:~/gnu/src/libgnupdf/trunk/doc$