Re: [pdf-devel] RE: Patch for 64bits failing tests

[Aleksander Morgado]

> 
> base/time/pdf-time-span-add.c:109:F:pdf_time_span_add:pdf_time_span_add_002:0:
>  Failure 'status != PDF_ERROR' occured
> base/time/pdf-time-span-copy.c:93:F:pdf_time_span_copy:pdf_time_span_copy_002:0:
>  Failure 'status != PDF_ERROR' occured
> base/time/pdf-time-span-diff.c:105:F:pdf_time_span_diff:pdf_time_span_diff_002:0:Failure
>  'status != PDF_ERROR' occured 
> 
> BTW, shouldn't those tests be expecting a PDF_EBADDATA ?
> They're expecting a PDF_ERROR when they're giving a NULL parameter.
> 


Yes, probably you're right. Time spans are stored as pdf_i64_t
internally, so probably we are facing the same issue here. Those
Time-Module unit tests should expect PDF_EBADDATA, as well as every unit
test testing wrong input arguments (like NULL pointers) in the methods.