phpgroupware-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Phpgroupware-developers] null return values in sql_entity


From: Dirk Schaller
Subject: [Phpgroupware-developers] null return values in sql_entity
Date: Wed, 1 Sep 2004 12:27:48 +0200

Hi guys,

does anyone knows the background why any functions of the sql_entity class
return null?
A return result of null is not feasible for error handling.

See function dekete:

        switch($action)
        {
        case PHPGW_SQL_RETURN_RECORDS:
        case PHPGW_SQL_RUN_SQL:
                $GLOBALS['phpgw']->db->query($sql, __LINE__, __FILE__);
                return;
        case PHPGW_SQL_RETURN_SQL:
                return $sql;
        }

The PHPGW_SQL_RUN_SQL case should be something like:
        return $GLOBALS['phpgw']->db->query($sql, __LINE__, __FILE__);

A true or false return values or the number of effected rows is better than
null.
What do you thing about? Could it be realized in a next version?

greetings
Dirk




reply via email to

[Prev in Thread] Current Thread [Next in Thread]