Re: SV: [Phpgroupware-developers] setup broken for phpgwapi upgrade in HEAD

[Benoit Hamet]

(Sorry for double posting)

Hi Sigurd,

Answer in the mail.

Sigurd Nes wrote:
> Fix one thing - break another...
> How about moving get_db_versions, compare_versions, and check_depends back 
> inside the loop -  check phpgwapi for update -  and if ['status'] == 'U' - do 
> an upgrade for phpgwapi before the loop start?

I fix the problem by changing this

>> If you take a look at that parts,
>> foreach($setup_info as $key => $value)
>> {
>>    if ( isset($value['name'])
>>         && $value['name'] != 'phpgwapi'
>>         && $value['status'] == 'U' )
>>    {
>>

I remove the $value['name'] != 'phpgwapi' test

then change the test in that if () {}
to :
if ( !(isset($passed[$value['name']]['status'])
     && $passed[$value['name']]['status'] != 'F'
     && $passed[$value['name']]['status'] != 'C') )

But I clearly fear to broke more thing ... that's why I was asking Dave
first :).

In fact I didn't understand so much the special case for phpgwapi ...
for me it's an app as another. The only things, it should be upgraded
first ... that could be done (as it's already done) by ordering the
$pass array ... I guess that's the purpose of the $pass['phpgapi'] =
$setup_info['phpgwapi'] ...

So no needs of more change IMHO.

The best will be to get the .16 setup version, take a look on how it
really works, then modify accordingly to what was expected ...

Does that make sense ?

Regards,

Caeies.