[Phpgroupware-tracker] [patch #142] [Patch #142] 0.9.14 - Addressbook - import vcard, others - inf. loop fix

[noreply]

Patch #142 has been updated. 

Project: 
Category: addressbook
Status: Open
Summary: 0.9.14 - Addressbook - import vcard, others - inf. loop fix

Follow-Ups:

Date: Sat 02/16/02 at 09:43
By: eparusel

Comment:
This patch addresses the following things:



1) For class.uivcard.inc.php, the output the user is fixed/prettied up...



2) For the "/addressbook/inc/import/Import_*" includes, there were a bunch of 
visual fixes, and there is also a infinite loop bug in Import_from_Netscape 
that is fixed...



The problem with Import_from_Netscape was the following statement:



for($i=1;$i<=count($buffer);$i++)



For whatever reason the middle argument to for() would always return true if a 
real LDIF file wasn't being uploaded...   Therefore there was an infinite loop 
adding blank records...  Not good :) 80,000 records added in ~ 60 seconds.



The following two statements work fine in replacement..



$recordcount = count($buffer);

for ($i=1;$i<=$recordcount;$i++)





Thanks,



Eric Parusel
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://savannah.gnu.org/patch/?func=detailpatch&patch_id=142&group_id=509

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/