pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make text data file use system native line ends by default.


From: Ben Pfaff
Subject: Re: [PATCH] Make text data file use system native line ends by default.
Date: Thu, 21 Mar 2013 21:45:29 -0700
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Mar 19, 2013 at 11:06:11AM -0700, Ben Pfaff wrote:
> On Mon, Mar 18, 2013 at 06:39:03PM +0100, John Darrington wrote:
> > The patch looks fine.  So long as it doesn't break any tests I'm happy
> > with it.  Except that I have heard that Mac OS, to assert its penchant
> > for non-conformance, uses neither LF, not CRLF, but LFCR.  However I
> > don't use Mac so I don't know if this rumour is correct.
> > 
> > I don't have any opinion about what the default on Windows should be.
> 
> I think what I'll do, when I have a few minutes, is to break this into
> two commits: a first commit that adds the new feature but maintains the
> current default behavior, and then a second commit that changes the
> Windows default to CRLF.  Then, if necessary, we can easily revert the
> second change.

I broke the commit into two as described and applied them to master.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]