Re: New Debian packaging effort

[bojo42]

First: Thanks for the review!

I already made most of the changes, so we may only discuss the
outstanding ones:

- Using the distro gnulib works on sid and Ubuntu precise (same gnulib
version) with only some different compiling output (see the strip diff
attachment), but not on Ubuntu lucid. I didn't testbuild for other
releases, but i doubt that is quite free of trouble. 

So while it's nice to use the Debian package it makes it less "portable"
as for backports and there is more need to adjust the package when the
gnulib changes. As i read on
http://lists.gnu.org/archive/html/bug-gnulib/2008-11/msg00269.html it's
also not strongly necessary to do so. So i would rather vote for
shipping a own separate tarball (source format "3.0 (quilt)" is really
nice for that), but maybe using the version from the Debian package.

- Setting debian/compat to 8 gives me troubles on my lucid machine with
debhelper, so i would like to stick to 7 for now.

- About debian/preinst, you're right that in Debian it's not needed
anymore and a simpler script can be used, cause Lenny is gone now. But i
also did it that way for supporting Ubuntu 10.04.

As you see i care a bit about doing easy backports. And because PSPP is
quite flexible on that, i like the packaging to do the same. So IMO
bringing the package to the debhelper 7 area and keeping it clean is
nice, but introducing unnecessary backporting blockers in the package
rather isn't ;)

Will upload to new version to mentors again, once we have that cleared.

One thing i like to propose is declaring you as an Uploader in
debian/control, what do you think?

Cheers

bojo42


Am Dienstag, den 17.01.2012, 06:50 -0800 schrieb Ben Pfaff:
> [trying again without quoting 900 kB]
> 
> The packaging looks pretty good to me.  I added some comments in
> review.  I'll sponsor you, if you will fix the (fairly small)
> issues that I pointed out.
> 
> Thanks,
> 
> Ben.
> 
> bojo42 <address@hidden> writes:
> 
> > I've just uploaded the revamped package to mentors:
> >
> > http://mentors.debian.net/package/pspp
> >
> > Feedback or sponsoring highly welcome :)
> >
> > Am Donnerstag, den 12.01.2012, 23:11 +0100 schrieb bojo42:
> >> Thanks, the testsuite is now quite pleased beside the 64bit one.
> >> 
> >> Am Donnerstag, den 12.01.2012, 20:30 +0000 schrieb John Darrington:
> >> > I pushed a change to master which should fix this FAILED item.
> >> > 
> >> > The first skipped on seems to be deliberately skipped on 64bit
> >> > systems.
> >> > 
> >> > For the other two items, you will need to have installed 
> >> > libtext-diff-perl and postgresql
> >> > 
> >> > J'
> >> > 
> >> > On Thu, Jan 12, 2012 at 06:18:13PM +0100, bojo42 wrote:
> >> >      I just tried to build for Ubuntu 10.04 (lucid) and the upcoming 
> >> > 12.04
> >> >      (precise). As precise is quite close to sid it got the same errors, 
> >> > but
> >> >      the testsuite is sucessful for the lucid build. So the reason for
> >> >      failure seems to be somewhere in the newer toolchain and 
> >> > dependencies.
> >> >      Maybe this helps a bit further.
> >> >      
> >> >      Am Donnerstag, den 12.01.2012, 13:17 +0100 schrieb bojo42:
> >> >      > Okay i fixed my pbuilder setup and now i can deliver anything 
> >> > from the
> >> >      > build chroot before it's deleted, see attachment.
> >> >      > 
> >> >      > @John: You guessed right i missed to depend on perl (also on 
> >> > libpq), but
> >> >      > having it added now doesn't help with the errors. Debian's perl 
> >> > is at
> >> >      > 5.14.2.
> >> >      > 
> >> >      > Am Mittwoch, den 11.01.2012, 10:27 -0800 schrieb Ben Pfaff:
> >> >      > > bojo42 <address@hidden> writes:
> >> >      > > 
> >> >      > > > - What still prevents compilation are some testsuite strikes:
> >> >      > > >
> >> >      > > >  20: numeric format output    FAILED (data-out.at:47)
> >> >      > > >  97: too many value labels    skipped 
> >> > (sys-file-reader.at:2766)
> >> >      > > >  183: GET DATA /TYPE=PSQL    skipped (get-data-psql.at:124)
> >> >      > > >  914: Perl Pspp.t    skipped (perl-module.at:706)
> >> >      > > >
> >> >      > > > Could really use some help for the FAILED one. Do you really 
> >> > need the
> >> >      > > > "testsuite.log" as it's quite tricky to get it out of my 
> >> > pbuilder setup.
> >> >      > > 
> >> >      > > I don't know how to debug a test failure without testsuite.log.
> >> >      > > 
> >> >      > > You can always add "cat testsuite.log" somewhere in your build
> >> >      > > process to ensure that testsuite.log shows up in the build log.
>

git_to_distro_gnulib_sid.diff
Description: Text Data