qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v15 00/15] PTimer fixes/features and ARM MPTimer c


From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH v15 00/15] PTimer fixes/features and ARM MPTimer conversion
Date: Mon, 5 Sep 2016 23:12:35 +0100

On 5 September 2016 at 22:52, Dmitry Osipenko <address@hidden> wrote:
> On 05.09.2016 21:14, Peter Maydell wrote:
>> I tried "check this compiles and passes the tests for each commit",
>> and what I found was that you get a lot of new warnings running
>> 'make check' about "Timer with period zero, disabling", which were
>> not there before. Could you look into this and fix it, please?

> Sure, I'll silence those ptimer error messages by making them conditional of
> qtest_enabled(). The messages are actually harmless, however not very useful 
> in
> the context of testing. Thanks a lot for returning to that series, I 
> appreciate it.

I had a look at the rest of the patches, but to be honest I found
it very difficult to figure out whether any of the changes were
making the right changes or the wrong changes. So it's not clear
to me that "silence the warning if running under qtest" is right:
why is the warning being produced at all?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]