Re: [Qemu-block] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium

[Eric Blake]

On 06/03/2015 01:44 PM, Max Reitz wrote:
> Introduce a new QMP command 'blockdev-change-medium' which is intended
> to replace the 'change' command for block devices. The existing function
> qmp_change_blockdev() is accordingly renamed to
> qmp_blockdev_change_medium().
> 
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  blockdev.c                |  7 ++++---
>  include/sysemu/blockdev.h |  2 --
>  qapi-schema.json          |  6 ++++--
>  qapi/block-core.json      | 23 +++++++++++++++++++++++
>  qmp-commands.hx           | 31 +++++++++++++++++++++++++++++++
>  qmp.c                     |  2 +-
>  6 files changed, 63 insertions(+), 8 deletions(-)
> 

> +++ b/qapi/block-core.json
> @@ -1909,6 +1909,29 @@
>  
>  
>  ##
> +# @blockdev-change-medium:
> +#
> +# Changes the medium inserted into a block device by ejecting the current 
> medium
> +# and loading a new image file which is inserted as the new medium (this 
> command
> +# combines blockdev-open-tray, blockdev-remove-medium, blockdev-insert-medium
> +# and blockdev-close-tray).
> +#
> +# @device:          block device name
> +#
> +# @filename:        filename of the new image to be loaded
> +#
> +# @format:          #optional, format to open the new image with (defaults to
> +#                   the probed format)
> +#
> +# Since: 2.3

/me the temptation is strong to go back on my word in 26 - ...must resist...

:)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature