Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default

[Gerd Hoffmann]

  Hi,

> +                             git describe 2>/dev/null | tr -d '\n'; \
> +                             if ! git diff-index --quiet HEAD &>/dev/null; 
> then \
> +                                     printf -- '-dirty'; \
> +                             fi \

/me suggests "git describe --dirty --match 'v*'"

Saves the extra effort to check for a dirty tree manually.

Also greatly reduces the chance non-release tags are matched, so I don't
get results like "pull-vga-20160523-1-236-g9fd5eb7".

cheers,
  Gerd