[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 01/13] iscsi: Use block size as minimum zero/disc
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH v2 01/13] iscsi: Use block size as minimum zero/discard alignment |
Date: |
Wed, 1 Jun 2016 15:10:01 -0600 |
If hardware does not advertise a minimum zero/discard
alignment, we still want to guarantee that the block layer
will align requests to our blocks, rather than the arbitrary
512-byte BDRV sector size.
Signed-off-by: Eric Blake <address@hidden>
---
block/iscsi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index e7d5f7b..94f9974 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1711,6 +1711,8 @@ static void iscsi_refresh_limits(BlockDriverState *bs,
Error **errp)
}
bs->bl.discard_alignment =
sector_limits_lun2qemu(iscsilun->bl.opt_unmap_gran, iscsilun);
+ } else {
+ bs->bl.discard_alignment = iscsilun->block_size >> BDRV_SECTOR_BITS;
}
if (iscsilun->bl.max_ws_len < 0xffffffff) {
@@ -1720,6 +1722,9 @@ static void iscsi_refresh_limits(BlockDriverState *bs,
Error **errp)
if (iscsilun->lbp.lbpws) {
bs->bl.write_zeroes_alignment =
sector_limits_lun2qemu(iscsilun->bl.opt_unmap_gran, iscsilun);
+ } else {
+ bs->bl.write_zeroes_alignment =
+ iscsilun->block_size >> BDRV_SECTOR_BITS;
}
bs->bl.opt_transfer_length =
sector_limits_lun2qemu(iscsilun->bl.opt_xfer_len, iscsilun);
--
2.5.5
- [Qemu-block] [PATCH v2 00/13] Kill sector-based write_zeroes, Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 01/13] iscsi: Use block size as minimum zero/discard alignment,
Eric Blake <=
- [Qemu-block] [PATCH v2 03/13] block: Add .bdrv_co_pwrite_zeroes(), Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 02/13] block: Track write zero limits in bytes, Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 06/13] qcow2: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 05/13] iscsi: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 13/13] block: Kill bdrv_co_write_zeroes(), Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 08/13] gluster: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 04/13] block: Switch bdrv_write_zeroes() to byte interface, Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 07/13] blkreplay: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/06/01
- [Qemu-block] [PATCH v2 09/13] qed: Convert to bdrv_co_pwrite_zeroes(), Eric Blake, 2016/06/01