[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 05/17] block/nbd-client: get rid of
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 05/17] block/nbd-client: get rid of ssize_t |
|
Date: |
Mon, 7 Aug 2017 09:24:03 +0100 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Mon, Aug 07, 2017 at 09:57:30AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 04.08.2017 19:11, Daniel P. Berrange wrote:
> > On Fri, Aug 04, 2017 at 06:14:28PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > Use int variable for nbd_co_send_request return value (as
> > > nbd_co_send_request returns int).
> > Hmm, nbd_co_send_request() propagates return value of nbd_send_request,
> > which returns ssize_t.
>
> See patch 04, nbd_send_request fixed in it to return int. It propagates
> return
> value of nbd_write which is int.
That's wrong too - nbd_write() should have been fixed to have ssize_t
as its return type, since its returning the value of a ssize_t variable.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-block] [PATCH 08/17] block/nbd-client: rename nbd_recv_coroutines_enter_all, (continued)
- [Qemu-block] [PATCH 09/17] block/nbd-client: move nbd_co_receive_reply content into nbd_co_request, Vladimir Sementsov-Ogievskiy, 2017/08/04
- [Qemu-block] [PATCH 15/17] block/nbd-client: refactor reading reply, Vladimir Sementsov-Ogievskiy, 2017/08/04
- [Qemu-block] [PATCH 01/17] nbd/client: fix nbd_opt_go, Vladimir Sementsov-Ogievskiy, 2017/08/04
- [Qemu-block] [PATCH 05/17] block/nbd-client: get rid of ssize_t, Vladimir Sementsov-Ogievskiy, 2017/08/04
- Re: [Qemu-block] [PATCH 05/17] block/nbd-client: get rid of ssize_t, Eric Blake, 2017/08/25
- [Qemu-block] [PATCH 02/17] nbd/client: refactor nbd_read_eof, Vladimir Sementsov-Ogievskiy, 2017/08/04
Re: [Qemu-block] [PATCH 00/17] nbd client refactoring and fixing, Eric Blake, 2017/08/16
Re: [Qemu-block] [PATCH 00/17] nbd client refactoring and fixing, Eric Blake, 2017/08/25