[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185 |
Date: |
Tue, 8 Aug 2017 10:07:17 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/08/2017 04:04 AM, Vladimir Sementsov-Ogievskiy wrote:
>>>> Throttling "guaranties" that there will not be more than one
>>>> request. But
>>>> what prevent less than one, i.e. zero, like in my reproduction?
>>> Yes, I understand. Can we somehow make sure that at least one iteration
>>> is made? I'd really like to keep the functional test for block job
>>> throttling. I suppose a simple 'sleep 0.1' would do the trick, though
>>> it's not very clean.
>>>
>>> Kevin
>>
>>
>> I've started with 'sleep 0.5', now there are >100 successful
>> iterations... The other way is to check in test that there was 0 or 1
>> requests, but for this it looks better to rewrite it in python.
>>
>>
>
> is sleep for ms portable?
Sadly, sub-second sleep is a GNU coreutils feature; I suspect the BSD
machines may fail to parse it. (Of course, we could do some sort of
'sleep $SMALL', where $SMALL is 0.5 if sleep supports it, and 1 otherwise).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] iotests: fix 185, (continued)
- Re: [Qemu-block] [PATCH] iotests: fix 185, Kevin Wolf, 2017/08/07
- Re: [Qemu-block] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [PATCH] iotests: fix 185, Kevin Wolf, 2017/08/08
- Re: [Qemu-block] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185,
Eric Blake <=
- Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185, Vladimir Sementsov-Ogievskiy, 2017/08/08
- Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185, Kevin Wolf, 2017/08/08
- Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185, Eric Blake, 2017/08/08