[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 3/7] block/sheepdog: remove spurious NULL check
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PATCH v2 3/7] block/sheepdog: remove spurious NULL check |
Date: |
Wed, 30 Aug 2017 12:57:00 -0400 |
'tag' is already checked in the lines immediately preceding this check,
and set to non-NULL if NULL. No need to check again, it hasn't changed.
Signed-off-by: Jeff Cody <address@hidden>
---
block/sheepdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index abb2e79..bbbfa72 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -1632,7 +1632,7 @@ static int sd_open(BlockDriverState *bs, QDict *options,
int flags,
if (!tag) {
tag = "";
}
- if (tag && strlen(tag) >= SD_MAX_VDI_TAG_LEN) {
+ if (strlen(tag) >= SD_MAX_VDI_TAG_LEN) {
error_setg(errp, "value of parameter 'tag' is too long");
ret = -EINVAL;
goto err_no_fd;
--
2.9.5
- [Qemu-block] [PATCH v2 0/7] Code cleanup and minor fixes, Jeff Cody, 2017/08/30
- [Qemu-block] [PATCH v2 3/7] block/sheepdog: remove spurious NULL check,
Jeff Cody <=
- [Qemu-block] [PATCH v2 2/7] block/ssh: make compliant with coding guidelines, Jeff Cody, 2017/08/30
- [Qemu-block] [PATCH v2 5/7] block/curl: check error return of curl_global_init(), Jeff Cody, 2017/08/30
- [Qemu-block] [PATCH v2 6/7] block/curl: fix minor memory leaks, Jeff Cody, 2017/08/30
- [Qemu-block] [PATCH v2 4/7] block/sheepdog: code beautification, Jeff Cody, 2017/08/30