[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 5/7] block/curl: check error ret
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 5/7] block/curl: check error return of curl_global_init() |
Date: |
Wed, 30 Aug 2017 14:49:45 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 08/30/2017 11:57 AM, Jeff Cody wrote:
> If curl_global_init() fails, per the documentation no other curl
> functions may be called, so make sure to check the return value.
>
> Also, some minor changes to the initialization latch variable 'inited':
>
> - Make it static in the file, for clarity
> - Change the name for clarity
> - Make it a bool
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> block/curl.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/block/curl.c b/block/curl.c
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/7] block/ssh: don't call libssh2_init() in block_init(), (continued)
[Qemu-block] [PATCH v2 3/7] block/sheepdog: remove spurious NULL check, Jeff Cody, 2017/08/30
[Qemu-block] [PATCH v2 2/7] block/ssh: make compliant with coding guidelines, Jeff Cody, 2017/08/30
[Qemu-block] [PATCH v2 5/7] block/curl: check error return of curl_global_init(), Jeff Cody, 2017/08/30
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 5/7] block/curl: check error return of curl_global_init(),
Eric Blake <=
[Qemu-block] [PATCH v2 6/7] block/curl: fix minor memory leaks, Jeff Cody, 2017/08/30
[Qemu-block] [PATCH v2 4/7] block/sheepdog: code beautification, Jeff Cody, 2017/08/30
[Qemu-block] [PATCH v2 7/7] block/curl: code cleanup to comply with coding style, Jeff Cody, 2017/08/30