[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition |
Date: |
Thu, 31 May 2018 09:01:13 +0100 |
On Thu, May 31, 2018 at 1:43 AM, John Snow <address@hidden> wrote:
> Commit d759c951f changed the main thread lock release/reacquisition,
> and in so doing apparently jostled loose a race condition in the AHCI
> code.
>
> Patch 2 should be sufficient to fix this, and patches 1 and 3 are just
> little trivial fixes.
>
> This might be sufficient to fix the bug as reported at
> https://bugs.launchpad.net/qemu/+bug/1769189
> but the nature of the timing changes make it difficult to confirm,
> so I am posting this patchset for the reporters to help test.
>
> John Snow (3):
> ahci: trim signatures on raise/lower
> ahci: fix PxCI register race
> ahci: don't schedule unnecessary BH
>
> hw/ide/ahci.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
Nice find!
Reviewed-by: Stefan Hajnoczi <address@hidden>
- [Qemu-block] [PATCH 0/3] ahci: fix completion race condition, John Snow, 2018/05/30
- [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH, John Snow, 2018/05/30
- [Qemu-block] [PATCH 2/3] ahci: fix PxCI register race, John Snow, 2018/05/30
- [Qemu-block] [PATCH 1/3] ahci: trim signatures on raise/lower, John Snow, 2018/05/30
- Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition,
Stefan Hajnoczi <=
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition, Bruce Rogers, 2018/05/31
- Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition, John Snow, 2018/05/31