[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower |
Date: |
Thu, 31 May 2018 11:38:24 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/31/2018 10:56 AM, Eric Blake wrote:
> On 05/30/2018 07:43 PM, John Snow wrote:
>> These functions work on the AHCI device, not the individual
>
> s/device/state/ ?
>
It's confusing; the AHCI device itself (the HBA) is represented by the
struct AHCIState. the SATA devices are referred to by "AHCIDevice".
Not great names, admittedly.
--js
>> AHCI devices, so trim the AHCIDevice argument.
>>
>> Signed-off-by: John Snow <address@hidden>
>> ---
>> hw/ide/ahci.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>
- [Qemu-block] [PATCH 0/3] ahci: fix completion race condition, John Snow, 2018/05/30
- [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH, John Snow, 2018/05/30
- [Qemu-block] [PATCH 2/3] ahci: fix PxCI register race, John Snow, 2018/05/30
- [Qemu-block] [PATCH 1/3] ahci: trim signatures on raise/lower, John Snow, 2018/05/30
- Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition, Stefan Hajnoczi, 2018/05/31
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition, Bruce Rogers, 2018/05/31
- Re: [Qemu-block] [PATCH 0/3] ahci: fix completion race condition, John Snow, 2018/05/31