Re: [Qemu-devel] Re: [WIN32] tftp issue

[Johannes Schindelin]

Hi,

On Sun, 10 Oct 2004, Magnus Damm wrote:

>
> > More informations: under linux with the same image and the same files I
> > get complete transfert, md5 checksum are the same for originals and
> > transfered files on guest (tested with command.com, msdos.sys and
> > license.txt :) if that matter)
>
> Hm.. could it be the good old missing O_BINARY flag to open()?

Indeed, in slirp/tftp.c:103, there is an open without O_BINARY.

BTW, I did a simple grep through all sources, and there are quite a few
open()s without the O_BINARY flag, and even one (in dyngen.c) which uses
the O_BINARY flag only on Windows. Is there any sane reason not to use
O_BINARY *everytime* in an open()? After all, we are not dealing with text
files here. And if we were, we would not like to change the line endings
on the fly, and ^Z simulating an EOF on Windows...

Ciao,
Dscho