[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] make stdio monitor default
From: |
Jim C. Brown |
Subject: |
Re: [Qemu-devel] make stdio monitor default |
Date: |
Sun, 20 Mar 2005 14:56:08 -0500 |
User-agent: |
Mutt/1.4i |
On Sun, Mar 20, 2005 at 11:26:12AM +0000, Paul Brook wrote:
> Have you tested this patch? It looks like it does the opposite of what you
> are
> suggesting.
>
> Paul
>
>
Whoops I sent the wrong one. Here is the right version:
--- vl.c.old Fri Mar 18 23:01:24 2005
+++ vl.c Fri Mar 18 23:02:03 2005
@@ -3031,7 +3031,11 @@
has_cdrom = 1;
cyls = heads = secs = 0;
translation = BIOS_ATA_TRANSLATION_AUTO;
+#ifdef _WIN32
pstrcpy(monitor_device, sizeof(monitor_device), "vc");
+#else
+ pstrcpy(monitor_device, sizeof(monitor_device), "stdio");
+#endif
pstrcpy(serial_devices[0], sizeof(serial_devices[0]), "vc");
for(i = 1; i < MAX_SERIAL_PORTS; i++)
> I agree, although I think the proper fix is to move the logic into the
> configure script and make it a configure time option.
> ie ./configure --enable-monitor=foo would set the default.
Interesting idea. I'll see if I can set this up and send a diff.
--
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.