Re: A Fix Re: APM bug Re: [Qemu-devel] Re: Suggestion - trap window-close of VM

[Volker Ruppert]

Hi,

> > I needed to patch the BIOS - which didn't implement the APM 1.2 16-bit
> > protected mode interface that Windows 2000 apparently requires.
> >...
> >
> > What doesn't work yet is Standby and Suspend, although I've generalised
>
> My network (using -user-net) stops working when I use your patched BIOS.
>
> But it does close the window on shutdown!

I guess the patched rombios is based on a newer version from Bochs CVS. Qemu 
is still using the rombios of May 31, 2004 with some patches. In the meantime 
the PCI IRQ routing table has been modified and the PCI IRQ initialization 
has been added. Qemu needs a small patch to make it work again. I have 
already sent this patch to Fabrice Bellard and posted it here in the list, 
but nothing happened. I'd like to apply the APM patch to the official Bochs 
BIOS if you can confirm that it works. Here is the patch:

diff -urN /home/volker/qemu/hw/pci.c ./hw/pci.c
--- /home/volker/qemu/hw/pci.c  2004-10-09 23:25:21.000000000 +0200
+++ ./hw/pci.c  2004-12-24 20:10:50.000000000 +0100
@@ -494,7 +494,7 @@
 static inline int pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num)
 {
     int slot_addend;
-    slot_addend = (pci_dev->devfn >> 3);
+    slot_addend = (pci_dev->devfn >> 3) - 1;
     return (irq_num + slot_addend) & 3;
 }
 
--
Bye

Volker