Re: [Qemu-devel] -cc checking wrong

[Paul Brook]

On Monday 08 May 2006 01:18, Jim C. Brown wrote:
> On Mon, May 08, 2006 at 12:46:24AM +0200, Pavel Jan?k wrote:
> > configure contains:
> >
> > if [ ! -x "`which $cc`" ] ; then
> >     echo "Compiler $cc could not be found"
> >     exit
> > fi
> >
> > You should check if the command compiles, not if it exists and is
> > executable.
>
> Patch attached. Simply tries to compile a dummy program.

You really should test your patches. The patch you attached generates an error 
if the compiler works.

Paul