Re: [Qemu-devel] [PATCH 1/5] Fix i386 Host

[Alexander Graf]

Johannes Schindelin wrote:
> Hi,
>
> I get an error with sh4-linux-user and sh4eb-linux-user:
>
> ../dyngen -o op.h op.o
> dyngen: ret or jmp expected at the end of op_cmp_str_T0_T1
>
>   

Yes, and it's mostly right about this. This specific opcode ends with a
jmp, which dyngen does not allow. I leave this to the SH4 developers, as
they know way better what this opcode is supposed to do.

> There is a "RETURN();" statement at the end of 
> target-sh4/op.c:op_cmp_str_T0_T1() though, so I am puzzled...
>   

It simply doesn't help ;-).

> It also says "target-ppc/exec.h:44:26: error: #if with no expression", 
> because there is an "#if GCC_BREAKS_T_REGISTER" which wants to be an 
> "#ifdef".  (This is in patch 1/5.)
>
>   

Fixed. Thank you.