Re: [Qemu-devel] [PATCH 1/5] Fix i386 Host

[Johannes Schindelin]

Hi,

On Thu, 17 Jan 2008, Alexander Graf wrote:

> Johannes Schindelin wrote:
> > Hi,
> >
> > On Thu, 17 Jan 2008, Alexander Graf wrote:
> >
> >   
> >> Alexander Graf wrote:
> >>     
> >>> Jens Arm wrote:
> >>>   
> >>>       
> >>>> With this I can compile, but qemu segfaults now when trying to start a 
> >>>> ros image:
> >>>>
> >>>> Starting program: /home/tux/QEMU/qemu -m 192 ros/ros
> >>>> [Thread debugging using libthread_db enabled]
> >>>> [New Thread -1212344640 (LWP 18268)]
> >>>>
> >>>> Program received signal SIGSEGV, Segmentation fault.
> >>>> [Switching to Thread -1212344640 (LWP 18268)]
> >>>> 0x08bcb3b4 in code_gen_buffer ()
> >>>> (gdb) bt
> >>>> #0  0x08bcb3b4 in code_gen_buffer ()
> >>>> #1  0x080de65b in cpu_x86_exec (env1=0x9c497e8) at 
> >>>> /home/tux/compile/qemu/cpu-exec.c:679
> >>>> #2  0x0805738f in main (argc=119537671, argv=0x20000720) at 
> >>>> /home/tux/compile/qemu/vl.c:7445
> >>>>
> >>>> Any hints?
> >>>>         
> >>> Looks like it's still broken. This can only be something minor, as it 
> >>> did work for me in between, but now I can reproduce you failure here 
> >>> as well. Stay tuned.
> >>>       
> >> Oh well, take 3 it is then.
> >>
> >> This patch should work for most targets now. All comments so far should 
> >> be integrated too, so if you're missing something you said, please tell 
> >> me.
> >>     
> >
> > It fixed it for me, but only after a "make distclean && ./configure && 
> > make".  Apparently there are still some dependencies which are not right.
> >
> > Thanks,
> > Dscho
> >   
> I changed the configure script, so this is quite reasonable.

I found two extra #endifs, in target-mips/exec.h and target-ppc/exec.h.  I 
updated my "gcc4" branch.

BTW the problem with sh4 seems to be specific to the function 
op_cmp_str_T0_T1() (commenting out the cond_t() call makes the funny 
"ret;andl;jmp" go away).

Ciao,
Dscho