Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

[Daniel Jacobowitz]

On Wed, Feb 13, 2008 at 09:46:44AM +0100, Marius Groeger wrote:
>   if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK) &&
>      !ctx->singlestep_enabled) {
>   ..
>   } else {
>     gen_set_T1(dest);
> #if defined(TARGET_PPC64)
>     if (ctx->sf_mode)
>       gen_op_b_T1_64();
>      else
> #endif
>       gen_op_b_T1();
>     if (ctx->singlestep_enabled)
>       gen_op_debug()
>   }
> 
> It seems to me that the second if (ctx->singlestep_enabled) is 
> rendundant.

No, if you've gone to a different page without single step then you
don't need the debug trap.

-- 
Daniel Jacobowitz
CodeSourcery