|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH] New scriptarg=... -net parameter allows passing of an argument |
Date: | Fri, 13 Jun 2008 01:04:51 +0300 |
User-agent: | Thunderbird 2.0.0.14 (X11/20080501) |
Anthony Liguori wrote:
Environment variables are global, whereas scriptarg is per-interface. Consider the case where scriptarg denotes the bridge name we want the interface to attach to.Right, what I'm suggesting is that scriptarg=... use an environmental variable (for instance, named SCRIPTARG) when executing the actual script instead of passing it as the second parameter.It's nicer IMHO because it extends well to passing more data to the script (like whatever the -name parameter is).
Ah, okay. I don't much like environment variables but I do see the advantages here.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
[Prev in Thread] | Current Thread | [Next in Thread] |