Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver.

[Blue Swirl]

On 8/4/08, Gerd Hoffmann <address@hidden> wrote:
>  +/* i386 protocol version */
>  +#pragma pack(push, 4)

What's wrong with __attribute__(__aligned__)?

>  + *  FIXME: the code is designed to handle multiple outstanding
>  + *  requests (using aio or using threads), which isn't used right
>  + *  now due to limitations of the qemu block driver interface.

Yes, what happened to vectored DMA patches?

>  +    RING_PUSH_RESPONSES_AND_CHECK_NOTIFY(&blkdev->rings.common, 
> send_notify);

EUGLY_LONG_NAME_WITH_ALL_CAPS

>  +       mode   = O_RDONLY;
>  +       qflags = BDRV_O_RDONLY;
>  +       info  |= VDISK_READONLY | VDISK_REMOVABLE | VDISK_CDROM;

Does this mean that all read-only disks are assumed to be CDROMs or
that all removable disks are read-only?

Why IF_XEN?

Why different protocols for i386 and x86_64? Would I need to add
Sparc32 and Sparc64 versions some day?