Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver

[Gerd Hoffmann]

Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <address@hidden> wrote:
>>  +const unsigned char atkbd_set2_keycode[512] = {
> 
> Missing "static"?

Yep, I'll fix it up.

>>  +       for (i = 0; i < 128; i++) {
>>  +           scancode2linux[i] = atkbd_set2_keycode[atkbd_unxlate_table[i]];
>>  +           scancode2linux[i | 0x80] =
>>  +               atkbd_set2_keycode[atkbd_unxlate_table[i] | 0x80];
>>  +       }
> 
> Can't these table be calculated so that this initial run-time lookup
> is not needed?

Should be doable, yes.

> The framebuffer does not use dirty memory detection. Is this
> intentional? I understand that in Xen that's not possible.

The guest frontend driver does that and sends the info to the backend
driver (XENFB_TYPE_UPDATE messages).

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/