Re: [Qemu-devel] Preliminary patch to implement ehci

[Glauber Costa]

On Mon, Oct 27, 2008 at 12:00 PM, Anthony Liguori <address@hidden> wrote:
> Mark Burkley wrote:
>>
>> Hi folks,
>>
>> Just checking, did anyone get a chance to look at this?
>>
>> Any suggestions for next steps?  Should I post a patch against trunk?
>>
>
> Submitting the patch against 0.9.1 is a non-starter.  0.9.1 is at least a
> year old and the USB code has been majorly refactored.  If you want people
> to review it, it has to be against trunk.
>
> Also make sure that you include a [PATCH] in your subject.  Otherwise, it's
> easily missed on the list.
The chances of anyone reviewing a patch that big is also very small.
So please, split it in minor, self-contained patches so it make it
easier for reviewers.

>
> Regards,
>
> Anthony Liguori
>
>> Thanks,
>>
>> Mark
>>
>
>
>
>



-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."