[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/3] dyngen: fix some warnings about unused func
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 2/3] dyngen: fix some warnings about unused functions |
Date: |
Thu, 13 Nov 2008 18:10:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Mark McLoughlin wrote:
> Warnings were:
>
> dyngen.c:292: error: ‘pstrcpy’ defined but not used
>
> Only used with CONFIG_FORMAT_COFF
>
> dyngen.c:319: error: ‘swab32ss’ defined but not used
>
> With ELF_USES_RELOCA, either swab32ss() or swab64ss() will
> be used depending on ELF_CLASS. Easier to just mark them
> both as unused.
>
> dyngen.c:334: error: ‘get16’ defined but not used
> dyngen.c:343: error: ‘get32’ defined but not used
> dyngen.c:352: error: ‘put16’ defined but not used
> dyngen.c:359: error: ‘put32’ defined but not used
>
> Maybe be used for some host arches; easiest to mark them as
> unused.
>
> dyngen.c:425: error: ‘elf_swap_phdr’ defined but not used
>
> This one is completely unused; just delete.
As far as I understood, the whole file will disappear soon (once ongoing
PPC conversion to TCG is completed). I gave up hunting after the dyngen
warning mess for this reason.
However, welcome to the club of warning fighters! Hope you'll have more
luck than others (including me). :)
Jan
--
Siemens AG, Corporate Technology, CT SE 2 ES-OS
Corporate Competence Center Embedded Linux