qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Adds null check for DisplayStatus (wasRe: [Qemu-devel] [6344


From: Stefano Stabellini
Subject: Re: [PATCH] Adds null check for DisplayStatus (wasRe: [Qemu-devel] [6344] graphical_console_init change (Stefano Stabellini)
Date: Mon, 19 Jan 2009 15:31:03 +0000
User-agent: Thunderbird 2.0.0.14 (X11/20080505)

Shin-ichiro KAWASAKI wrote:

> Stefano Stabellini wrote:
>> Shin-ichiro KAWASAKI wrote:
>>
>>> I'm sending the patch which solves the problem above.
>>> Could anyone evaluate it?
>>>
>>
>>
>>
>> Thanks for spotting the bug and your work on a patch!
>>
>> However I think the following fix is cleaner: we do not need a
>> dumb_display_init that creates an empty DisplayChangeListener any more.
>> We do need a dumb_display_init that allocates a zeroed DisplayState
>> structure if none else does it.
>>
>> Please let me know if it also fixes you problem.
> 
> It solves my problem finely.  Thank you!
> 
> Tested-by: Shin-ichiro KAWASAKI <address@hidden>
> 

Thanks for testing it.
Anthony, before committing this patch, check out the other equivalent
patch I sent as I reply to 'add a -vga none cli option'.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]