[Qemu-devel] Re: [PATCH 3/5] Introduce rules.mak

[Anthony Liguori]

Avi Kivity wrote:
> Add a file for common makefile rules.
>
> Signed-off-by: Avi Kivity <address@hidden>
>
> (Don't forget to 'svn add')
> ---
>  Makefile        |    8 ++------
>  Makefile.target |    7 +------
>  rules.mak       |   10 ++++++++++
>  3 files changed, 13 insertions(+), 12 deletions(-)
>  create mode 100644 rules.mak
>
> diff --git a/Makefile b/Makefile
> index 92a77ba..66e61fc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,6 +7,8 @@ include config-host.mak
>  
>  VPATH=$(SRC_PATH):$(SRC_PATH)/hw
>  
> +include rules.mak
>   

This breaks the build from an external directory.  You at least need to 
do include $(SRC_PATH)/rules.mak

I noticed you didn't cover the ar command, any particular reason?

Regards,

Anthony Liguori