Re: [Qemu-devel] Machine description as data prototype, take 3

[Paul Brook]

On Thursday 19 February 2009, Markus Armbruster wrote:
> Paul Brook <address@hidden> writes:
> > On Thursday 19 February 2009, Markus Armbruster wrote:
> >> Third iteration of the prototype.
> >>
> >> What about an early merge?  If your answer to that is "yes, but", what
> >> exactly do you want changed?
> >
> > I dislike that you've got everything lumped together. In its current form
> > it's unclear that it's actually an improvement from what we currently
> > have. There still seems to be an awful lot of code that's extremely PC
> > specific, and I can't tell whether/which interfaces achieve separation
> > from the legacy hardcoded PC nastyness and generic machine descriptions.
>
> I think I got the PC nastiness encapsulated in driver methods.  I can
> put them into a separate file if you think that would help.

That would definitely help.

In principle there should be no PC specific code. It should all be either 
generic code (in dt.c or similar), or device specific code (in the 
appropriate device implementations).

Paul