Re: [Qemu-devel] [patch 1/7] qemu: mutex/thread/cond wrappers

[Jamie Lokier]

Avi Kivity wrote:
> >+int qemu_mutex_init(QemuMutex *mutex)
> >+{
> >+    return pthread_mutex_init(&mutex->lock, NULL);
> >+}
> 
> No one will check the return code, so better to check it here and 
> abort() if it's bad.

I agree.

Same applies to pthread_mutex_lock, etc., all of which return an error
code, can fail if misused, and nobody checks.

-- Jamie